Replace docs.rs build doc_auto_cfg feature with doc_cfg#710
Merged
tnull merged 1 commit intolightningdevkit:release/0.7from Nov 19, 2025
Merged
Replace docs.rs build doc_auto_cfg feature with doc_cfg#710tnull merged 1 commit intolightningdevkit:release/0.7from
doc_auto_cfg feature with doc_cfg#710tnull merged 1 commit intolightningdevkit:release/0.7from
Conversation
Unfortunately, `doc_auto_cfg` was removed, breaking doc builds for v0.7.0-rc.0. Here we replace it with the `doc_cfg` attribute.
|
👋 Thanks for assigning @tankyleo as a reviewer! |
tankyleo
approved these changes
Nov 19, 2025
Contributor
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
Looked up docs.rs docs, thought you might want to add this to CI somewhere instead of the script we've got in LDK:
https://docs.rs/about/builds#testing-builds-ci
https://github.com/dtolnay/cargo-docs-rs
Collaborator
Author
Yeah, maybe that would be worth. For now going ahead landing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately,
doc_auto_cfgwas removed, breaking doc builds for v0.7.0-rc.0. Here we replace it with thedoc_cfgattribute.